Properly override toString in CompileError #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
==========================================
+ Coverage 92.06% 92.08% +0.02%
==========================================
Files 115 115
Lines 4297 4297
Branches 1369 1369
==========================================
+ Hits 3956 3957 +1
+ Misses 148 147 -1
Partials 193 193
Continue to review full report at Codecov.
|
esarbanis
force-pushed
the
override-toString
branch
from
e80235e to
b1909dc
Compare
|
Huh! TIL. Thanks |
sacrosanctic
pushed a commit
to sacrosanctic/svelte
that referenced
this pull request
Dec 24, 2024
* migrate everything but the page stores section to $app/state * move redirects from tutorial into handle hooks: keeps all redirects on one place, less prerendered pages for stuff that's increasingly rotten, fixes a bug with the specific redirects not working currently (they were missing from entries) * replace $app/stores tutorial with $app/state * bump kit * small tweaks * update * Update apps/svelte.dev/content/tutorial/03-sveltekit/08-app-state/01-page-state/index.md Co-authored-by: Conduitry <[email protected]> * Update apps/svelte.dev/content/tutorial/03-sveltekit/08-app-state/01-page-state/index.md * Update apps/svelte.dev/content/tutorial/03-sveltekit/08-app-state/02-navigating-state/index.md Co-authored-by: Conduitry <[email protected]> * Update apps/svelte.dev/content/tutorial/03-sveltekit/08-app-state/03-updated-state/index.md Co-authored-by: Conduitry <[email protected]> * Update apps/svelte.dev/content/tutorial/03-sveltekit/08-app-state/03-updated-state/index.md * Apply suggestions from code review * bump, use <page.data.component> directly * update * revert * only update kit * get the damn thing working * sure, prettier, let's suddenly start complaining about these files for some reason * undo some other upgrade that fucked up syntax highlighting for some insane reason. fuck me i fucking hate computers * i don't fucking believe this --------- Co-authored-by: Rich Harris <[email protected]> Co-authored-by: Conduitry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug actually breaks most of the test cases in svelte-loader, when svelte's version is updated to the current one.